Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the logic and functionality used by the "featured" fields on Stories #1317

Closed
16 of 17 tasks
kevwalsh opened this issue Mar 24, 2020 · 7 comments
Closed
16 of 17 tasks

Improve the logic and functionality used by the "featured" fields on Stories #1317

kevwalsh opened this issue Mar 24, 2020 · 7 comments
Labels
Content forms [CMS feature] crew-sitewide Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide Story CMS managed product owned by Facilities team UX writing CMS team practice area UX VAMC CMS managed product owned by Facilities team

Comments

@kevwalsh
Copy link
Contributor

kevwalsh commented Mar 24, 2020 •
edited by jilladams
Loading

Background

  1. Ethan Teague wrote / merged front-end code in VACMS-1317: Update logic to use order field instead of featured field. content-build#680 to partially address this issue.
  2. CMS code to make changes was written & is in closed PR VACMS-1317: Update feature display logic. #6766.
  3. Strategy around updating Featuring has changed since, and this ticket can either be:

Screenshot_2021-09-02__12_50_PM

Screenshot_2021-09-02__12_50_PM

ACs

  • Featured UI matches for Stories and Events.
    • Get Events featured fieldset out of right rail
  • Works with whatever FE is doing for VAMC events and Outreach hub.
    • Remove boolean from Graphql
  • Remove the boolean field and replace "- No -" with "Not featured"
  • Help text that explains what the FE will do if there's more than one story or event with same "Featured" position.
  • "List page" view
    • Fields for both
      • Node title linked to content
      • Featured status ("First feature", "Second feature", and nothing for "Not featured",
      • Moderation state
    • "Stories list" display
    • "Events list" display
      • Add start date field
      • Sort by start date ASC
      • Filter out past events (or filter for "past and featured" AND "future", depending on how FE is configured)
  • Design review
@oksana-c oksana-c added the Needs refining Issue status label Dec 30, 2020
@oksana-c oksana-c changed the title Improve the logic and functionality used by the "featured" fields on news releases and stories. Improve the logic and functionality used by the "featured" fields on Events and Stories Dec 30, 2020
@kevwalsh kevwalsh added Content forms [CMS feature] Drupal engineering CMS team practice area UX writing CMS team practice area labels Sep 2, 2021
@ethanteague ethanteague self-assigned this Oct 19, 2021
This was referenced Oct 23, 2021
Merged
Closed
@kevwalsh kevwalsh removed this from the CMS Sprint 45 - Sitewide CMS team milestone Nov 21, 2021
@kevwalsh kevwalsh removed the Needs refining Issue status label Dec 10, 2021
@xiongjaneg
Copy link
Contributor

sorry, accidentally removed the sprint 50 label from this one, then put it back

@kevwalsh kevwalsh mentioned this issue Feb 14, 2022
Closed
23 tasks
@kevwalsh kevwalsh mentioned this issue Feb 28, 2022
Closed
19 tasks
@jilladams
Copy link
Contributor

Note for when Events gets more priority: PR #6766 is open, with comment:

Taking into account this thread: https://dsva.slack.com/archives/C01H29ERVJ7/p1645211875246399 , not sure how to proceed with this. Sounds like Dave wants to explore options for this for a while, and maybe the path forward is to revert the front end work I did in department-of-veterans-affairs/content-build#680, and let facilities team do it some other way, then merge in this pr once that is sorted?

& Note from Kev that the help text needs a content edit.

@jilladams jilladams mentioned this issue Nov 1, 2022
Closed
13 tasks
@swirtSJW swirtSJW mentioned this issue Jan 18, 2023
Closed
4 tasks
@swirtSJW
Copy link
Contributor

This could be either a Public Websites issue or a Facilities Issue. It is most likely a Facilities issue to tackle only because they are by far the biggest user of the "featured" aspect.

@swirtSJW swirtSJW added Facilities Facilities products (VAMC, Vet Center, etc) Defect Something isn't working (issue type) labels Jan 18, 2023
@swirtSJW
Copy link
Contributor

@JayDarnell I am adding the defect label because right now the "featured" aspect does not work the way anyone expects it to work and does not work the way the help text says it should work.

@davidmpickett davidmpickett added the VAMC CMS managed product owned by Facilities team label Mar 16, 2023
@davidmpickett davidmpickett added the Events product maintained by Public Websites team label Apr 27, 2023
@jilladams
Copy link
Contributor

New occurrence of how this is now affecting Lovell: https://dsva.slack.com/archives/C0FQSS30V/p1683224452110549

@jilladams
Copy link
Contributor

We will not standardize this behavior, as the old mechanism for Featuring will be retired from Events entirely, and re-envisioned for Stories. Facilities owns the task moving forward, which may use an entirely different re-envisioned functionality.

Leaving ticket open, and it may / should probably move to the new Facilities epic for Future state, when it is opened.

@jilladams jilladams mentioned this issue May 11, 2023
Open
@jilladams jilladams changed the title Improve the logic and functionality used by the "featured" fields on Events and Stories Improve the logic and functionality used by the "featured" fields on Stories May 11, 2023
@mmiddaugh mmiddaugh added Story CMS managed product owned by Facilities team and removed Events product maintained by Public Websites team labels Aug 16, 2023
@xiongjaneg xiongjaneg added the UX label Aug 18, 2023
@mmiddaugh mmiddaugh mentioned this issue Jan 29, 2024
Open
@davidmpickett davidmpickett mentioned this issue Sep 18, 2024
Closed
2 tasks
@davidmpickett
Copy link
Contributor

Closing as duplicate of #13695

@davidmpickett davidmpickett closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Content forms [CMS feature] crew-sitewide Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide Story CMS managed product owned by Facilities team UX writing CMS team practice area UX VAMC CMS managed product owned by Facilities team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@acrollet @kevwalsh @ethanteague @swirtSJW @oksana-c @davidmpickett @mmiddaugh @xiongjaneg @jilladams