Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ContentReleaseEntityEventSubscriber service. #13852

Closed
2 tasks done
Tracked by #14441
ndouglas opened this issue May 25, 2023 · 0 comments · Fixed by #14337
Closed
2 tasks done
Tracked by #14441

Create ContentReleaseEntityEventSubscriber service. #13852

ndouglas opened this issue May 25, 2023 · 0 comments · Fixed by #14337
Assignees
@ndouglas
Labels
CMS Team CMS Product team that manages both editor exp and devops Content Release DevOps CMS team practice area

Comments

@ndouglas
Copy link
Contributor

ndouglas commented May 25, 2023 •
edited
Loading

Description

Following #13851 and followup tickets, #13854, and #13855, we should replace Drupal\va_gov_build_trigger\EventSubscriber\EntityEventSubscriber with a compact, well-written class that outsources its logical decisions to the ContentReleaseEntityEventResponseResolver service as described in #13851.

Acceptance Criteria

  • A new ContentReleaseEntityEventSubscriber service has been created to replace the EntityEventSubscriber class.
  • Unit tests confirm agreement with the previous system.
@ndouglas ndouglas added the CMS Team CMS Product team that manages both editor exp and devops label Jun 21, 2023
@productmike productmike added the DevOps CMS team practice area label Jul 5, 2023
@ndouglas ndouglas mentioned this issue Jul 12, 2023
Merged
14 tasks
@ndouglas ndouglas self-assigned this Jul 17, 2023
@productmike productmike mentioned this issue Jul 19, 2023
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndouglas ndouglas

Labels
CMS Team CMS Product team that manages both editor exp and devops Content Release DevOps CMS team practice area
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VACMS-13852: Creates EntityEvent Subscriber. ndouglas/va.gov-cms
2 participants
@ndouglas @productmike