Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine path forward for client side validation. #15241

Closed
3 tasks done
BlakeOrgan opened this issue Sep 13, 2023 · 2 comments
Closed
3 tasks done

Determine path forward for client side validation. #15241

BlakeOrgan opened this issue Sep 13, 2023 · 2 comments
Assignees
Labels
CMS design system CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area

Comments

@BlakeOrgan
Copy link
Contributor

BlakeOrgan commented Sep 13, 2023

Description

Tony did some discovery on the client side validation module to see if it can only be applied to the the alt text input field. Depending on if that is possible or not will depend on the path that we take to move forward. Generally speaking, client side validation is a positive thing, but we would want to be aware on where clientside validation will need to be turned on if it's not able to only be applied to the alt text input field.

Acceptance Criteria

  • Meeting has occured between Tony, Blake, Laura meet to discuss findings from ticket 15020
  • Erika has approved the path forward that has been determined from this meeting
  • Path forward has been documented in the comments in this ticket.
@BlakeOrgan BlakeOrgan added Drupal engineering CMS team practice area Needs refining Issue status CMS design system CMS Team CMS Product team that manages both editor exp and devops labels Sep 13, 2023
@BerniXiongA6 BerniXiongA6 removed the Needs refining Issue status label Sep 13, 2023
@BlakeOrgan
Copy link
Contributor Author

@EWashb Based on our call with @laflannery, @tonytaylor, and @BerniXiongA6, we discussed that while it's not possible to turn on clientside validation for just the alt text input field on the add image page of the CMS, it IS possible to turn on clientside validation for all alt text input fields across the CMS. These are the pages that that input field appears on.

  • event
  • campaign_landing_page
  • press_release
  • outreach_asset
  • news_story
  • health_care_local_facility
  • health_care_region_page
  • vba_facility
  • vet_center
  • vet_center_cap
  • vet_center_mobile_vet_center
  • vet_center_outstation

With that being said, @laflannery suggested that we also enable clientside validation for all of the input fields used when uploading an image to the CMS in order to maintain a consistent experience while in that type of flow. I would also agree with that suggestion from a UX perspective, but I acknowledge that it would add to the scope of what we originally talked about. If we were to take that path forward instead, these are the following fields that clientside validation would need to be turned on for across the CMS.

  • Name
  • Description
  • Image
  • Alternative text
  • Section
  • Revision log message

@EWashb Before we decide to move forward, we wanted to get your thoughts on the two options to inform our next steps.

  1. Turn on clientside validation for all instances of alternative text input fields across the CMS. (Quick win for alt text quality, but could cause confusion with different types of error handling in image upload flows.)
  2. Turn on clientside validation for all instances of the input fields listed above across the CMS. (More consistent UX for error handling in image upload flows across the CMS, but increased scope. More risk than option 1, but less risk than turning on client side validation across the entire CMS as a whole.)

@laflannery and @tonytaylor Feel free to jump in if you feel I'm missing anything here!

@EWashb
Copy link
Contributor

EWashb commented Sep 21, 2023

After further discussion, I think no. 1 will be the best next step for this. I am looking at client-side validation for other types of errors in the system going forward. Please work @BerniXiongA6 to create the tickets for next steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS design system CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area
Projects
None yet
Development

No branches or pull requests

5 participants