Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map thumbnails for Vet Center CAPs do not render on the locations page #15656

Open
mmiddaugh opened this issue Oct 11, 2023 · 3 comments
Open
Labels
Defect Something isn't working (issue type) Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide Technical debt VA.gov frontend CMS team practice area Vet Center CMS managed product owned by Facilities team

Comments

@mmiddaugh
Copy link
Contributor

mmiddaugh commented Oct 11, 2023

Description

A Vet Center Locations page displays listings for the Main Vet Center along with, if affiliated, Outstations, Mobile Vet Centers, and CAPs.

Map thumbnails are displayed for the Main Vet Center and for Outstations but not for CAPs.
Example: On the Nashville Vet Center Locations page

  • there are thumbnails for the Main Vet Center and Clarksville Vet Center Outstation
  • there is no thumbnail for the Nashville Vet Center - Bowling Green

CAPs have a visible thumbnail in the Drupal interface but it is not rendered on the front end. The page briefly appears to try and load but ultimately, the map is not displayed.

Steps to reproduce

  1. View the Nashville Vet Center - Bowling Green CAP node in edit mode
  2. Scroll down page and observe the map is visible in the Geolocation block
  3. Visit the Nashville Vet Center Locations page
  4. Observe no map is displayed for Nashville Vet Center - Bowling Green

Note: map thumbnails are not expected for Mobile Vet Centers

Screenshots

Screenshot of CMS node for CAP image.png

Screenshot of Locations page image.png

Acceptance criteria

  • Map thumbnails for Vet Center Community Access Points are displayed on the relevant locations page below the images.
  • Appropriate spacing and padding is applied.
  • Map thumbnails are accessible to users of assistive tech
  • Interactions with CAP thumbnails have the same interactive behavior as other location thumbnails
@mmiddaugh mmiddaugh added Defect Something isn't working (issue type) Facilities Facilities products (VAMC, Vet Center, etc) VA.gov frontend CMS team practice area Vet Center CMS managed product owned by Facilities team labels Oct 11, 2023
@mmiddaugh
Copy link
Contributor Author

@xiongjaneg I think this might be a regression - I thought we previously displayed these

@mmiddaugh
Copy link
Contributor Author

Will consider this in context of Vet Center 2.0

@davidmpickett
Copy link
Contributor

Pretty sure this is blocked by #9727 or #4411. Map images are called from dynamically from Facilities API via Vets Website (rather than statically generated from Drupal data via Content Build). Vet Center CAPs were not in previous iteration of the API. If they were added to Lighthouse v1 (and therefore available in Vets API v2), then this would be an enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Something isn't working (issue type) Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status sitewide Technical debt VA.gov frontend CMS team practice area Vet Center CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

4 participants