Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright tests run in CI #16304

Closed
1 of 2 tasks
Tracked by #16310 ...
timcosgrove opened this issue Dec 5, 2023 · 3 comments
Closed
1 of 2 tasks
Tracked by #16310 ...

Playwright tests run in CI #16304

timcosgrove opened this issue Dec 5, 2023 · 3 comments

Comments

@timcosgrove
Copy link
Contributor

timcosgrove commented Dec 5, 2023

Requirements

We want Playwright tests to run in CI so that we can use the tests as a code quality marker and prevent new code from breaking existing functionality.

Acceptance criteria

Background & implementation details

Implementation tasks

@timcosgrove
Copy link
Contributor Author

This is only if #16240 does not fully get Playwright running on CI.

@olivereri
Copy link
Contributor

This required a significant amount of work much of it is documented in DSVA Slack. A quick summary however:

  • Platform provided GHA Self-hosted runner automation isn't flexible for custom packages
    • Solution: Fork the image creation workflows and Packer configs and run them in the next-build repository
    • Todo:
      • Fix Launch template updates
      • Remove Next-build from DevOps repo automation
  • The entire Playwright workflow depends on versions of Node that will not use TLS unsafe renegotiation. VA networking devices do NOT support safe TLS renegotiation,
    • Solution: Cache dependencies in the next-build repository for offline install, otherwise avoid Node fetches and perform downloads so that they'll use the system's UnsafeLegacyRenegotiation openssl configuration.

https://dsva.slack.com/archives/C01SR56755H/p1701821999818269
https://dsva.slack.com/archives/C01SR56755H/p1701795703847379
https://dsva.slack.com/archives/C01SR56755H/p1701730550664439
https://dsva.slack.com/archives/C01SR56755H/p1701376017432539
https://dsva.slack.com/archives/C01SR56755H/p1701128585606099

@tjheffner
Copy link
Contributor

Playwright runs in CI department-of-veterans-affairs/next-build#270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants