Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facility Locator detail pages: migrate to V1 #18183

Closed
1 task
jilladams opened this issue May 21, 2024 · 3 comments
Closed
1 task

Facility Locator detail pages: migrate to V1 #18183

jilladams opened this issue May 21, 2024 · 3 comments
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator detail page A page used in facility locator for non-modernized facility types Facility Locator product owned by Facilities team Lighthouse Facility API Data source/destination for many Facilities team products Needs refining Issue status sitewide Unplanned work Work that was introduced post-planning VA.gov frontend CMS team practice area

Comments

@jilladams
Copy link
Contributor

jilladams commented May 21, 2024

Backstory

https://dsva.slack.com/archives/C05RJS5DANT/p1716318543572679?thread_ts=1715799636.573629&cid=C05RJS5DANT

Facility Locator detail pages, e.g. https://www.va.gov/find-locations/facility/vc_0101V are dynamically built on the fly from a LH API call.

ACs

  • Facility Locator detail pages do not rely on LH V0 and appear successfully in prod
@jilladams jilladams added Facilities Facilities products (VAMC, Vet Center, etc) VA.gov frontend CMS team practice area Needs refining Issue status Unplanned work Work that was introduced post-planning Lighthouse Facility API Data source/destination for many Facilities team products Facility Locator product owned by Facilities team Facility Locator detail page A page used in facility locator for non-modernized facility types labels May 21, 2024
@jilladams
Copy link
Contributor Author

Eli has proposed that IIR handle this work (https://app.zenhub.com/workspaces/va-iir-6508c0bd79e64e0fb5855caf/issues/gh/department-of-veterans-affairs/va-iir/727). If they agree, we can close this ticket. If not, we will need to handle this.

@jilladams
Copy link
Contributor Author

If we have to handle: Work here would depend on how IIR handles the rest of the FL migration to V1. If their work merges without this piece, there's a chance the Facility Locator detail pages will be broken meantime.

@jilladams
Copy link
Contributor Author

IIR verified they'll handle under https://github.com/department-of-veterans-affairs/va-iir/issues/727. Closing!

@jilladams jilladams closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Facility Locator detail page A page used in facility locator for non-modernized facility types Facility Locator product owned by Facilities team Lighthouse Facility API Data source/destination for many Facilities team products Needs refining Issue status sitewide Unplanned work Work that was introduced post-planning VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

1 participant