CLP: View screen should match Edit screen in Drupal

[laflannery]

Status

[2024-09-06] [Dave] Pulled in to sprint as a Site Building ticket
[2024-08-15] [Fran] Prioritization not decided yet, but moving to Next Refinement so it will be ready in case this bubbles up.

Background

In Drupal for the Campaign Landing page content type, the edit screen has multiple sections that can be enabled to build the page. However, very few of these sections actually show on the View screen in Drupal when they are enabled. There is no issue on the FE - everything is working as expected on the FE - this is just a Drupal View issue.

This did however recently lead to quite a bit of confusion when Justin from VHA was trying to add the Downloadable resources section to a page for SECVA. He, as well as the Helpdesk all thought this section was not working because they couldn't see it being added in Drupal. Slack thread for reference

Description

In order to avoid future confusion, we should ensure that all enabled sections on a CLP are also shown on the View screen in Drupal.

Example (This is a tugboat link so it may break but I also have screenshots)

• Drupal Edit screen, I have enabled ALL sections, so this is everything that should be showing on the View screen

  • https://main-2pegzvqcy77ynmcultaityqtlrpfbfoo.demo.cms.va.gov/node/51214/edit
    

• Drupal Node view: Only Hero Banner, Why this matters, What can you do, and connect with us show in the accordion style. Then Reusable Q&A show below

  • https://main-2pegzvqcy77ynmcultaityqtlrpfbfoo.demo.cms.va.gov/initiatives/covid-flu
    

Acceptance Criteria

• All enabled sections on a CLP display on the View screen in the same order as the edit screen
• Optional sections that have never been enabled do not show on the View screen
  • Optional sections that have been enabled and then disabled may still show up on the View screen
• Requires QA

Issues out of scope

• Confusing error message when disabling the Stories panel on a CLP #19161
• Links with summaries field in Spotlight section of CLP does not indicate it is required #19163
• Strange Node View behavior for optional segments on CLP that have been enabled and then disabled #19165

[laflannery]

@mmiddaugh I wanted to just let you know I made a ticket for this but I'm not sure if it needs to be prioritized or not. But at least you know it exists now.

CC: @FranECross

[FranECross]

@laflannery Thanks so much! I'll move it to Next Refinement so that it'll be ready in case we do decide to prioritize.

[davidmpickett]

Notes:

• Video = not showing
• Spotlight = not showing
• Stories = not showing
• Downloadable resources = not showing
• Events = not showing
• FAQs = showing up at very bottom
• VA benefits = showing up inside of Connect with us

[davidmpickett]

Seems like the culprit here is a custom module that would hide unused widgets on View back before that was a core widget functionality (leave "Show if empty" unchecked)

[davidmpickett]

My work on the PR is basically done. Enabled and disabled sections are now functioning as expected. I have also rearranged/renamed/reformatted a few fields so the View and Edit screens match better.

Remaining work is writing up QA steps etc.

[davidmpickett]

@FranECross @mmiddaugh @laflannery - I would like to request a modification to one of the ACs:

• Sections not enabled do not show on the View screen

I have a solution working that partially resolves this. It won't show sections of the page that have never been enabled.

However, if an editor enables a section and then later disables it without manually clearing out the content, that content will still show on Node View. This is not ideal state, but I'd argue it's still functional.

Resolving this would require a much larger effort and would balloon the size of this ticket. We'd need to tag in an engineer and discuss tradeoffs of various possible solutions. I suggest that we ship my solution which improves 80% of the scenarios.

Here's a comparison from my QA of the current state in Prod vs the state in my tugboat:

✅ = Ideal state
⚠️ = Functional but not ideal
⛔ = Not functional

Scenario	Current prod behavior	Tugboat behavior
Create a new CLP with no optional panels	Hero banner ✅ Why this matters ✅ What can you do ⚠️ VA Benefits ⚠️	Hero banner ✅ Why this matters to you ✅ What you can do ✅ VA Benefits ✅
Create a new CLP with all optional panels	Hero banner ✅ Why this matters ✅ What can you do ⚠️ Video ⛔ Spotlight ⛔ Stories ⛔ Downloadable resources ⛔ Events ⛔ FAQs ⚠️ Connect with us ⚠️ VA Benefits ⚠️	Hero banner ✅ Why this matters ✅ What you can do ✅ Video ✅ Spotlight ✅ Stories ✅ Downloadable resources ✅ Events ✅ FAQs ✅ Connect with us ✅ VA Benefits ✅
Enable an optional panel on an existing CLP	Video ⛔ Spotlight ⛔ Stories ⛔ Downloadable resources ⛔ Events ⛔ FAQs ⚠️ Connect with us ⚠️	Video ✅ Spotlight ⚠️ Stories ✅ Downloadable resources ✅ Events ✅ FAQs ✅ Connect with us ✅
Disable an optional panel on an existing CLP	Video ✅ Spotlight ✅ Stories ⛔ Downloadable resources ✅ Events ✅ FAQs ⚠️ Connect with us ⚠️	Video ⚠️ Spotlight ⚠️ Stories ⛔ Downloadable resources ⚠️ Events ⚠️ FAQs ⚠️ Connect with us ✅

Edit and here are the issues I stubbed for the remaining quirks

• Confusing error message when disabling the Stories panel on a CLP #19161
• Links with summaries field in Spotlight section of CLP does not indicate it is required #19163
• Strange Node View behavior for optional segments on CLP that have been enabled and then disabled #19165

[FranECross]

@davidmpickett Thanks for providing the amazing table showing prod/future prod. I'm in favor of shipping with the 80% improvement, but defer to Michelle and Laura for final call.

[mmiddaugh]

Agree! The table is amazing and shipping an 80% improvement is a great win.
We may pursue an iteration to the CLP in CY4Q24 so heroic efforts otherwise can wait until then

[davidmpickett]

End of sprint update

• This is waiting for Code Review, but is low on the priority list given the other Drupal PRs in flight this sprint

[davidmpickett]

Verified on prod https://prod.cms.va.gov/initiatives/va-health-connect