Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery: Accessible design pattern for CMS table row hover states #9917

Closed
6 tasks done
EWashb opened this issue Jul 27, 2022 · 4 comments
Closed
6 tasks done

Discovery: Accessible design pattern for CMS table row hover states #9917

EWashb opened this issue Jul 27, 2022 · 4 comments
Labels
a11y-defect-1 Critical accessibility issue that should be fixed in the next sprint CMS Team CMS Product team that manages both editor exp and devops

Comments

@EWashb
Copy link
Contributor

EWashb commented Jul 27, 2022

Background

An accessibility audit found that on all products and all tables, the main content listing has tables that do not pass WCAG accessibility standards for hover states. Table rows currently have a hover state that changes to light blue.

On hover, the background color of the table rows changes to light blue. However, because of this, the color contrast between elements no longer passes:

  1. Between the links and the background
  2. And between the backgound and the link hover background color

Image of defective area:
Screen Shot 2022-07-27 at 12 36 47 PM

Possible Solution

There does not have to be a hover state on the table row, this can be removed if desired. Or if it should stay for design reasons, the color should be changed to make sure it passes ratio requirements with the standard link color and the link hover background color

Accessibility Standard

WCAG version 2.0 AA, Criterion 1.4.3

Acceptance Criteria

  • Discovery of table usage across products to determine if the hover is necessary for design or other reasons not immediately obvious in audit
  • WCAG AAA considered
  • Hover state pattern with appropriate color contrast for link color
  • Design is reviewed with Accessibility Lead
  • Document changes to links in the CMS DS and changelog
  • tech implementation ticket created
@EWashb EWashb added CMS Team CMS Product team that manages both editor exp and devops a11y-defect-1 Critical accessibility issue that should be fixed in the next sprint labels Jul 27, 2022
@EWashb EWashb changed the title Discovery: Accessible design pattern for table row hover states Discovery: Accessible design pattern for CMS table row hover states Jul 27, 2022
@EWashb
Copy link
Contributor Author

EWashb commented Jul 27, 2022

After fixing this issue, additional tickets for hover state color contrast on links across the CMS?

@EWashb
Copy link
Contributor Author

EWashb commented Jul 28, 2022

Hey team! Please add your planning poker estimate with ZenHub @cjterdi @laflannery

@cjterdi
Copy link

cjterdi commented Aug 2, 2022

Per our accessibility review for links, we have come up with the follow criteria. This applies to 9916 and 9915

All standard links will be changed to the dark blue (004795)
hover/focus state link color will be darker blue (003e73)
We think having a background color would be beneficial as this would keep it as a similar format as the front end (they have a background color on hover)
The hover/focus state should be the lighter blue (e4eff9). This is currently the color on some CMS links, not all. It is also different than the VA.gov front end hover color
Footer links will remain white
Footer links on hover/focus will keep their current background color (e4eff9) but the text will be darker blue (003e73)
All links should have underline on default and then no underline on hover/focus

@EWashb
Copy link
Contributor Author

EWashb commented Aug 4, 2022

Implementation ticket for these changes has been created.

@EWashb EWashb closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-defect-1 Critical accessibility issue that should be fixed in the next sprint CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

No branches or pull requests

2 participants