Use electron in place of phantomjs

[alexose]

Not only is PhantomJS not being super actively maintained, it is also notably slower than Electron.

It should be pretty straightforward to swap PhantomJS with Electron without having to change the tests much. However, due to subtle differences, we will have to repair some failing tests.

[alexose]

New implementation is up and being tested on the e2e-electron branch.

[alexose]

I've noticed two things that cause Electron to fail in places where Phantom didn't:

1. Click events require that the clicked element isn't overlapped by any other element. This is good to fix anyway.

2. Our smooth scrolling plugin causes some timing issues. I think this is because Electron is so much quicker to load pages. Anyway, I've implemented a way to override smooth scrolling for our E2E tests.

[alexose]

All tests are passing locally but continue to have issues in the Travis environment. The good news is that it's at least 25% faster with a lot more room for improvement.

[alexose]

Travis appears to be tripping over selectors for certain form elements. This isn't happening locally. I'm going to try to debug this in docker.

[alexose]

Successfully replicated it in docker. Definitely looks like some extra complexity introduced by xvfb.

Edit: Yep. The select go off the screen, meaning that they can't actually be clicked. Gonna fix this by verifying that the correct option element exists, then just setting the value with .setValue

[alexose]

Turns out that using .setValue doesn't trigger the change event, and it's not really possible to trigger change programmatically in React.

So, I wrote a snippet that uses the arrow keys instead of the mouse. This works fine in xvfb, but not in OSX. 🤦

There are still a couple of other issues I need to tackle, most importantly figuring out what is causing HCA not to validate: https://travis-ci.org/alexose/vets-website/jobs/185638483#L2492-L2524

[alexose]

Only one set of problems left at this point, which is the edit screen test in est/hca/06-edit-submission.e2e.spec.js. It's almost certainly a timing issue.

https://travis-ci.org/alexose/vets-website/jobs/187298791

[alexose]

Almost there, but I'm still seeing an issue with the accessibility tests. There's also some new work to be done now that #4481 has been merged.

[jcmeloni-zz]

Not moving over to vets.gov-team as this is captured in master ticket over there and will close it when that closes https://github.com/department-of-veterans-affairs/vets.gov-team/issues/578

[alexose-gov]

Done!

[jcmeloni-usds]

Yaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaay!!!!! 🎉