-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to auto-merge despite failing non-required CI checks #2661
Comments
Sort of related to this, I have an optional check that's tied to an approval step in CircleCI. Dependabot will not merge on approval (using It seems it would be preferable for dependabot to merge once all required checks have passed (if any exist) or once all checks have passed if none are required. |
👋 Hey there! Sorry for the glacially slow response... we've been a bit buried. This issue is pretty old, from old Dependabot-preview before it was integrated with GitHub. With the new Dependabot native, we unfortunately are not going to be supporting native auto-merge for the reasons outlined here. However, there is a documented workaround if you wish to setup auto-merge yourself. I'm going to close, as essentially this issue isn't relevant anymore since the old way of doing automerge doesn't exist. |
Sorry to dig up an old issue, but "using
and then never merge, even when all checks have passed. Is there a better place to bring this up? This repo, or GitHub community discussions perhaps? |
Hello!
I searched and couldn't find anything along these lines, other than #2132.
I'm not sure whether to classify this as a bug or a feature, but I guess per the documentation this is expected behavior:
As mentioned by some folks in #2132, we use a number of different status checks on GitHub, some of which are required, because they are required, and some of which are not required, because they, well, are not required. I understand the conservative default behavior of not auto-merging PRs with a failing non-required check, but the inability to override this behavior is adding quite a bit of friction to our workflow.
In summary, when one or more non-required checks (as configured by GitHub branch protection rules) fail and all required checks pass, Dependabot comments with:
and refuses to auto-merge the PR. My request is to allow toggling this behavior, at the organization level and/or at the repo level, to disregard failing non-required CI checks with respect to allowing auto-merge.
Thank you!
The text was updated successfully, but these errors were encountered: