Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to auto-merge despite failing non-required CI checks #2661

Closed
serhalp opened this issue Oct 19, 2020 · 3 comments
Closed

Option to auto-merge despite failing non-required CI checks #2661

serhalp opened this issue Oct 19, 2020 · 3 comments
Labels
T: feature-request Requests for new features

Comments

@serhalp
Copy link

serhalp commented Oct 19, 2020

Hello!

I searched and couldn't find anything along these lines, other than #2132.

I'm not sure whether to classify this as a bug or a feature, but I guess per the documentation this is expected behavior:

For all of the options below Dependabot will wait until all your status checks pass before merging.

As mentioned by some folks in #2132, we use a number of different status checks on GitHub, some of which are required, because they are required, and some of which are not required, because they, well, are not required. I understand the conservative default behavior of not auto-merging PRs with a failing non-required check, but the inability to override this behavior is adding quite a bit of friction to our workflow.

In summary, when one or more non-required checks (as configured by GitHub branch protection rules) fail and all required checks pass, Dependabot comments with:

One of your CI runs failed on this pull request, so Dependabot won't merge it.

and refuses to auto-merge the PR. My request is to allow toggling this behavior, at the organization level and/or at the repo level, to disregard failing non-required CI checks with respect to allowing auto-merge.

Thank you!

@elliotttf
Copy link

elliotttf commented Nov 23, 2021

Sort of related to this, I have an optional check that's tied to an approval step in CircleCI.

Screen Shot 2021-11-23 at 13 23 14

Dependabot will not merge on approval (using @dependabot squash and merge) as long as this optional check is incomplete.

It seems it would be preferable for dependabot to merge once all required checks have passed (if any exist) or once all checks have passed if none are required.

@jeffwidman
Copy link
Member

👋 Hey there! Sorry for the glacially slow response... we've been a bit buried.

This issue is pretty old, from old Dependabot-preview before it was integrated with GitHub. With the new Dependabot native, we unfortunately are not going to be supporting native auto-merge for the reasons outlined here. However, there is a documented workaround if you wish to setup auto-merge yourself.

I'm going to close, as essentially this issue isn't relevant anymore since the old way of doing automerge doesn't exist.

@bewuethr
Copy link

bewuethr commented Mar 8, 2023

Sorry to dig up an old issue, but "using @dependabot squash and merge doesn't result in a merge" is a different issue from auto-merge, isn't it? I see it saying

Dependabot will merge this PR once CI passes on it, as requested by @bewuethr.

and then never merge, even when all checks have passed.

Is there a better place to bring this up? This repo, or GitHub community discussions perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: feature-request Requests for new features
Projects
None yet
Development

No branches or pull requests

4 participants