Add python 3.9.2, 3.8.8, 3.7.10 and 3.6.13 #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feelepxyz
reviewed
Mar 8, 2021
| @@ -68,10 +68,10 @@ RUN apt-get install -y software-properties-common \ | |||
| ENV PYENV_ROOT=/usr/local/.pyenv \ | |||
| PATH="/usr/local/.pyenv/bin:$PATH" | |||
| RUN git clone https://github.com/pyenv/pyenv.git /usr/local/.pyenv \ | |||
| && cd /usr/local/.pyenv && git checkout v1.2.22 && cd - \ | |||
| && pyenv install 3.9.1 \ | |||
| && cd /usr/local/.pyenv && git checkout 9ee109b66148bc39a685926050b7b56cb4bb184b && cd - \ | |||
There was a problem hiding this comment.
Looks like it's released now https://github.com/pyenv/pyenv/releases/tag/v1.2.23
Suggested change
| && cd /usr/local/.pyenv && git checkout 9ee109b66148bc39a685926050b7b56cb4bb184b && cd - \ | |
| && cd /usr/local/.pyenv && git checkout v1.2.23 && cd - \ |
There was a problem hiding this comment.
Ah I see now that it doesn't include all the new versions.
There was a problem hiding this comment.
Yeah, 1.2.23 is missing 3.9.2 and 3.8.8
feelepxyz
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
LGTM 👍
Verified pyenv changes pyenv/pyenv@v1.2.22...9ee109b
There are some worrying changes to stackless installs going from https to http but we don't install these. Raised the issue pyenv/pyenv#1845
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.