Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Dependabot YML Linter on PR too #3878

Closed
hfhbd opened this issue Jun 10, 2021 · 2 comments
Closed

Run Dependabot YML Linter on PR too #3878

hfhbd opened this issue Jun 10, 2021 · 2 comments
Labels
T: bug 🐞 Something isn't working

Comments

@hfhbd
Copy link
Contributor

hfhbd commented Jun 10, 2021

Dependabot uses a yaml file for its settings. The linter for the yaml only runs on the main branch after a change, but not as a check during a PR request.
Please also run the linter in the PR request, to prevent merging invalide yaml configuration in the main branch.

Sample: hfhbd/routing-compose#9, no check and main ci with failing check https://github.com/hfhbd/routing-compose/runs/2791232493

@hfhbd hfhbd added the T: bug 🐞 Something isn't working label Jun 10, 2021
@Nishnha Nishnha added T: feature-request Requests for new features and removed T: bug 🐞 Something isn't working labels Jun 10, 2021
@jurre jurre added T: bug 🐞 Something isn't working and removed T: feature-request Requests for new features labels Jul 1, 2021
@jurre
Copy link
Member

jurre commented Jul 1, 2021

Thanks for reporting this, it should definitely run on PRs as long as the config file is changed. I'm digging in trying to figure out why this isn't working.

@jeffwidman
Copy link
Member

This is a dupe of #4605. Although this one is older, that one has more discussion, so closing this one.

@jeffwidman jeffwidman reopened this Oct 13, 2022
@jeffwidman jeffwidman closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants