Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot group update doesn't work on dockerfile #7938

Closed
1 task done
ying-jeanne opened this issue Aug 31, 2023 · 2 comments · Fixed by #7984
Closed
1 task done

Dependabot group update doesn't work on dockerfile #7938

ying-jeanne opened this issue Aug 31, 2023 · 2 comments · Fixed by #7984
Assignees
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR T: bug 🐞 Something isn't working

Comments

@ying-jeanne
Copy link

ying-jeanne commented Aug 31, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

Docker

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

The related log is https://github.com/ying-jeanne/mimir/network/updates/716250888

dependabot.yml content

here https://github.com/ying-jeanne/mimir/blob/test_group_update/.github/dependabot.yml

Updated dependency

any dependency in dockerfile, including the ones in the log
updater | +-------------------------------------+
updater | | Dependencies failed to update |
updater | +---------------------+---------------+
updater | | kustomize/kustomize | unknown_error |
updater | | alpine/helm | unknown_error |
updater | | golang | unknown_error |

What you expected to see, versus what you actually saw

dependency update for dockerfile works and one PR raised per dockerfile.

Native package manager behavior

this is not applied

Images of the diff or a link to the PR, issue, or logs

The related log is https://github.com/ying-jeanne/mimir/network/updates/716250888

Smallest manifest that reproduces the issue

you should be able to reproduce it with the same dependabot.yml by fork grafana/mimir repo

@ying-jeanne ying-jeanne added the T: bug 🐞 Something isn't working label Aug 31, 2023
@jakecoffman jakecoffman added L: docker Docker containers F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR labels Aug 31, 2023
@jurre jurre removed the L: docker Docker containers label Sep 6, 2023
@Nishnha
Copy link
Member

Nishnha commented Sep 6, 2023

Thank you for the report!
Adding some context from the logs

updater | ERROR undefined method `segments' for "1.21.0-bullseye":String
updater | 
updater |           major: version.segments[0] || 0,
updater |                         ^^^^^^^^^
updater | ERROR /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:233:in `semver_segments'
updater | ERROR /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:221:in `semver_rules_allow_grouping?'

This same error actually shows up in the logs twice:

updater | ERROR undefined method `segments' for "3.12.3":String

@Nishnha
Copy link
Member

Nishnha commented Sep 8, 2023

These dependencies should now be able to update correctly #7984

Screenshot 2023-09-08 at 12 46 08 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR T: bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants