Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Dependabot considers skipped runs as failures and does not merge corresponding pull requests #948

Closed
localheinz opened this issue Jun 2, 2020 · 1 comment
Closed

Dependabot considers skipped runs as failures and does not merge corresponding pull requests #948

localheinz opened this issue Jun 2, 2020 · 1 comment
Labels
T: bug 🐞 Something isn't working

Comments

@localheinz
Copy link

localheinz commented Jun 2, 2020 •
edited
Loading

Dependabot currently complains with the following message

Message

One of your CI runs failed on this pull request, so Dependabot won't merge it.

  • Delete
  • Create

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Screen Shot 2020-06-02 at 13 45 28

Jobs

However, these jobs have not failed, they have been skipped:

Screen Shot 2020-06-02 at 13 45 42

Handling

Perhaps something could be done on your end to distinguish between failed and skipped jobs? A skipped job is not necessarily an indication of a failure.

In this particular case, we have jobs that create (or remove) staging environments when a pull request has a specific label added (or removed).
@localheinz localheinz added the T: bug 🐞 Something isn't working label Jun 2, 2020
@infin8x infin8x mentioned this issue Jun 8, 2020
Closed
@jurre jurre mentioned this issue Jun 9, 2020
Closed
@tsimbalar tsimbalar mentioned this issue Jun 9, 2020
Closed
@feelepxyz
Copy link
Contributor

Pushed a fix for merging/automerging when there are skipped check runs. Rolling out fix for both versions of Dependabot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T: bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feelepxyz @localheinz