Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release workflow to leave php and ext-json requirements #3228

Closed
antonmedv opened this issue Jul 27, 2022 · 0 comments
Closed

Fix release workflow to leave php and ext-json requirements #3228

antonmedv opened this issue Jul 27, 2022 · 0 comments

Comments

@antonmedv
Copy link
Member

Currently the package could be installed on PHP 7.2 (php7.2 /usr/bin/composer require deployer/deployer) as there are no version constraints, but will fail after running php7.2 vendor/bin/dep with error message Your Composer dependencies require a PHP version ">= 7.3.0"... (this error is generated by platform_check.php inside the PHAR).

That does not seem ideal to me, as in my opinion the package should at least require PHP version 7.3+ and ext-json to prevent installing it on older PHP version or with json extension disabled. The remaining dependencies symfony/*, psr/http-message etc. need not be required, as they are already packaged inside the PHAR.

Originally posted by @nufue in #3224 (reply in thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant