Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate audio-caption rule #1071

Merged
merged 2 commits into from
Aug 21, 2018
Merged

feat: Deprecate audio-caption rule #1071

merged 2 commits into from
Aug 21, 2018

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented Aug 15, 2018

Disabling / deprecating this rule. Audio captions do not work (https://www.iandevlin.com/blog/2015/12/html5/webvtt-and-audio/), and there are other ways to make audio accessible.

Closes #997.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: Jey (@JKODU)

@WilcoFiers WilcoFiers requested a review from a team as a code owner August 15, 2018 10:19
@jeeyyy
Copy link
Contributor

jeeyyy commented Aug 15, 2018

The problem with axe-codeowners is that, when someone outside of the team approves you do not pass the waiting on code review check. The status still remains as review required.

image

Copy link
Contributor

@dylanb dylanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does someone determine a rule that is deprecated?

@WilcoFiers
Copy link
Contributor Author

@dylanb There's a ticket open #1062 to figure out how to notify users of deprecated stuff in axe-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants