-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow only-dlitem / only-listitem to have any hidden content #1098
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree with the treatment of aria-hidden
To elaborate: aria-hidden="true"
is intended to hide things from the assistive technology. It is not intended to override semantics. role="presentation"
is intended to override semantics.
); | ||
}); | ||
|
||
it('returns false if there are aria-hidden=true elements that normally would not be allowed', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm, I don't agree with this case
); | ||
}); | ||
|
||
it('returns false if there are aria-hidden=true elements that normally would not be allowed', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with this
@dylanb I don't understand your point. Assistive technologies treat elements with aria-hidden exactly the same way as they do elements with <ul>
<template is="dom-repeat">
<li>{{text}}</li>
</template>
<li>Item 1</li>
<li>Item 2</li>
</ul> <ul>
<dom-repeat style="display:none;">
<li>{{text}}</li>
</dom-repeat>
<li>Item 1</li>
<li>Item 2</li>
</ul> <ul>
<dom-repeat aria-hidden="true" style="position:absolute; top:-999em;">
<li>{{text}}</li>
</dom-repeat>
<li>Item 1</li>
<li>Item 2</li>
</ul> |
ok, I was mistaken in thinking this was a 4.1.1 rule and not a 1.3.1 rule |
This change allows any hidden element in ul, ol and dl elements.
Closes #1021
Reviewer checks
Required fields, to be filled out by PR reviewer(s)