style(locales): proofreading of the french translations #2485
Conversation
|
|
|
Thanks for the pr. We're trying to get one of our previous French contributors to verify the changes, so this may take a bit to get merged. But we'll get it in before the next release. |
locales/fr.json
Outdated
| @@ -355,13 +355,13 @@ | |||
| }, | |||
| "aria-roledescription": { | |||
| "pass": "aria-roledescription utilisé sur un élément sémantique supporté", | |||
| "incomplete": "Vérifier que la valeur de aria-roledescription est annoncée par les lecteurs d'écran supportés", | |||
| "incomplete": "Vérifier que la valeur d'aria-roledescription est annoncée par les lecteurs d'écran supportés", | |||
There was a problem hiding this comment.
There's a few ' instead of the curly ’. I'm not sure if that matters to you but just noticed a few places where they were in. Up to you if you'd like to update them but we can merge as is. Just let me know.
There was a problem hiding this comment.
Indeed I forgot a lot of them 😅 I fixed this in the following commit
There was a problem hiding this comment.
Please use an apostrophe (’) rather than a prime ('). I have strong feelings about this 😅
There was a problem hiding this comment.
@stephenmathieson i did it in the commit ca645dc. I double checked, normally I did not miss any.
|
Sorry about the failing tests. We just merged a pr to fix them. Please merge latest develop into your branch to resolve the problems. |
fixed basic typos replaced "s'assure que" by "vérifier que" removed subjunctive forms typography: homogenized apostrophes typography: added spaces before : and ! fixed singular / plural fixed genders added some elisions of vowels Closes issue #2484
fixed basic typos replaced "s'assure que" by "vérifier que" removed subjunctive forms typography: homogenized apostrophes typography: added spaces before : and ! fixed singular / plural fixed genders added some elisions of vowels Closes issue #2484
Closes issue #2484
Reviewer checks
Required fields, to be filled out by PR reviewer(s)