Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put back act test aria-props-permitted #3132

Closed
straker opened this issue Aug 24, 2021 · 2 comments
Closed

put back act test aria-props-permitted #3132

straker opened this issue Aug 24, 2021 · 2 comments
Assignees
Labels
pr A pr has been created for the issue tech debt Technical debt related tasks
Milestone

Comments

@straker
Copy link
Contributor

straker commented Aug 24, 2021

We had to remove the test so we could release 4.3.3. We need to put it back when we do a 4.4 release which will include the appropriate fix.

@straker straker added the tech debt Technical debt related tasks label Aug 24, 2021
@straker straker added this to the Axe-core 4.4 milestone Aug 24, 2021
@WilcoFiers
Copy link
Contributor

Discussed yesterday. What we're going to do is pin the ACT repo to a specific commit in package.json, and then in our nightly script install #master so that we have daily reporting if anything breaks that we haven't included yet.

@padmavemulapati
Copy link

Validated with the latest develop branch code base, aria-allowed-attribute rule is now passing for attribute aria-busy and aria-owns and failing with earlier attribute aria-selected and audio
Script:

<div id="target" tabindex="1" aria-selected="true" aria-checked="true"></div>
      <div id="target" tabindex="1" aria-busy="true" aria-owns="foo"></div>
      <div id="target" tabindex="1" aria-selected="true" aria-owns="foo"></div>
      <audio
  src="/test/assets/moon-speech.mp3"
  controls
  aria-orientation="horizontal"
  id="failCase"
></audio>

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr A pr has been created for the issue tech debt Technical debt related tasks
Projects
None yet
Development

No branches or pull requests

4 participants