feat: add new ARIA roles #3138
feat: add new ARIA roles #3138
Conversation
|
|
Zidious
changed the title
There was a problem hiding this comment.
Great start! Since some of these roles have attributes, owned elements, or prohibited attributes, we'll need to add a few more tests to make sure they are all covered
- test/integration/rules/aria-allowed-attr/failure - add elements to ensure
markandsuggestiondo not allowaria-labelandaria-labelledby - test/integration/rules/aria-allowed-attr/passes - add element for
commentto allowaria-level,aria-posinset, andaria-setsize - test/integration/rules/aria-required-children - add pass and fail tests for
suggestionhavinginsertionanddeletionchildren/aria-owns
| <span role="insertion">option</span> | ||
| </div> | ||
|
|
||
| <div role="suggestion" id="fail8"> |
There was a problem hiding this comment.
Good start. So with our integration tests we want to be really thorough and test all possible states, so we'll want 3 more tests added. One for suggestion without any children, and one for suggestion with just an insertion child, and one for suggestion with just a deletion child.
There was a problem hiding this comment.
Unable to test for one child due to requiredOwned (as discussed). However ARIA Suggestion Docs say that both need to be present, playground throws no errors if using one child
Zidious
force-pushed
the
addariaroles
branch
from
20794da to
f51b5a3
Compare
There was a problem hiding this comment.
LGTM. Will wait for @WilcoFiers final approve.
@WilcoFiers the main question we have is how to handle the role=suggestion element requiring that it owns both a role=insertion and role=deletion element. Currently aria-required-children will pass if at least one role is owned, but not enforce all roles.
|
@straker Suggestion doesn't require both roles. MDN is wrong about that:
Either way, it's so early days on this spec, I don't think we should be too harsh on testing just yet. |
ARIA 1.3 Annotations Added new roles: mark, suggestion, and comment.
Closes issue: #3122