fix(p-as-heading): p-as-heading rule to account for textContent length

[Zidious]

Ref: #3130

[straker]

@WilcoFiers we had questions on this requirement:

I would say that if the heading is longer than the paragraph, we pass it. If it's less than twice as long, we set it for review, and only if the suspected fake heading is at least 200% shorter than the paragraph do we allow it to be failed.

There's a gap in the algorithm, like what happens if it's more than twice as long but not greater than the length. Could you give a bit more clarification? Here's what I have reading that description:

const headingLength = headingEl.textContent.length;
const paragraphLength = pEl.textContext.length;

if (headingLength > paragraphLength) {
  return true;
}
else if (headingLength < paragraphLength / 2) {
  return false;
} 
else {
  return undefined;
}

[WilcoFiers]

@straker I think your dummy code is pretty much how I think of it. We should probably put in options to make these values configurable. Beyond that, these seem like reasonable heuristics for this rule.

[Zidious]

@straker I think your dummy code is pretty much how I think of it. We should probably put in options to make these values configurable. Beyond that, these seem like reasonable heuristics for this rule.

@WilcoFiers Could you provide a bit more info on configurable by options?

resolved

[WilcoFiers]

One comment, rest looks good.

resolved

resolved