Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-allowed-attr): check for invalid aria-attributes for role="row" #3160

Merged
merged 16 commits into from
Oct 1, 2021

Conversation

Zidious
Copy link
Contributor

@Zidious Zidious commented Sep 15, 2021

aria-posinset, aria-setsize, aria-expanded, and aria-level must not be applied to a row that descends from a table or grid

closes issues: #3151 & #2794

@Zidious Zidious marked this pull request as ready for review September 17, 2021 13:58
@Zidious Zidious requested a review from a team as a code owner September 17, 2021 13:58
@Zidious Zidious changed the title draft: check for invalid aria-attributes for role="row" fix: check for invalid aria-attributes for role="row" Sep 17, 2021
lib/checks/aria/aria-allowed-attr-evaluate.js Outdated Show resolved Hide resolved
lib/checks/aria/aria-allowed-attr-evaluate.js Outdated Show resolved Hide resolved
lib/checks/aria/aria-allowed-attr-evaluate.js Outdated Show resolved Hide resolved
lib/checks/aria/aria-allowed-attr-evaluate.js Outdated Show resolved Hide resolved
lib/checks/aria/aria-allowed-attr-evaluate.js Outdated Show resolved Hide resolved
lib/checks/aria/aria-allowed-attr-evaluate.js Outdated Show resolved Hide resolved
lib/checks/aria/aria-allowed-attr-evaluate.js Outdated Show resolved Hide resolved
lib/checks/aria/aria-allowed-attr-evaluate.js Outdated Show resolved Hide resolved
lib/checks/aria/aria-allowed-attr-evaluate.js Outdated Show resolved Hide resolved
lib/checks/aria/aria-allowed-attr-evaluate.js Outdated Show resolved Hide resolved
lib/checks/aria/aria-allowed-attr.json Show resolved Hide resolved
lib/checks/aria/aria-allowed-attr.json Outdated Show resolved Hide resolved
@Zidious Zidious changed the title fix: check for invalid aria-attributes for role="row" fix(aria-allowed-atr): check for invalid aria-attributes for role="row" Oct 1, 2021
@Zidious Zidious changed the title fix(aria-allowed-atr): check for invalid aria-attributes for role="row" fix(aria-allowed-attr): check for invalid aria-attributes for role="row" Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants