fix: Separate Level AAA rules from A and best-practices #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
previously requested changes
Oct 6, 2021
straker
previously requested changes
Oct 7, 2021
lib/core/base/audit.js
Outdated
Comment on lines
594
to
595
| const unmatchedTags = only.values.filter(tag => !tags.includes(tag)); | ||
| if (unmatchedTags.length !== 0) { | ||
| log('Could not find tags `' + unmatchedTags.join('`, `') + '`'); | ||
| if (unmatchedTags.length !== 0 && !/wcag2[1-3]a{1,3}/.test(unmatchedTags)) { |
There was a problem hiding this comment.
This hides all other unknown tags, so passing this would not log that foo is an unknown tag:
axe.run({ runOnly: ['wcag23a', 'foo'] });We should instead filter out the wcag tags from the unmatched ones.
Suggested change
| const unmatchedTags = only.values.filter(tag => !tags.includes(tag)); | |
| if (unmatchedTags.length !== 0) { | |
| log('Could not find tags `' + unmatchedTags.join('`, `') + '`'); | |
| if (unmatchedTags.length !== 0 && !/wcag2[1-3]a{1,3}/.test(unmatchedTags)) { | |
| const unmatchedTags = only.values.filter(tag => !tags.includes(tag) && !/wcag2[1-3]a{1,3}/.test(tag)); | |
| if (unmatchedTags.length !== 0) { |
Also add a test to show this still reports unknown tags when used with an allowed wcag tag
straker
previously approved these changes
Oct 8, 2021
straker
approved these changes
Oct 11, 2021
straker
pushed a commit
that referenced
this pull request
Oct 18, 2021
* fix: Separate Level AAA rules from A and best-practices * Don't log use of wcag21aaa as a tag * address comments
This was referenced Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Dylan's suggestion, and according to our own API docs the AAA tag should never have been used on rules tagged at a different level, or as best practice. This PR puts ensures AAA rules are now treated as its own "type" or rule.
Closes issue: #3190