fix(color-contrast): correctly work with positioned elements without z-index #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Oct 15, 2021
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
approved these changes
Oct 18, 2021
straker
added a commit
that referenced
this pull request
Oct 18, 2021
…z-index (#3209) * fix(color-contrast): correctly work with positioned elements without z-index * correct link * add back test * fix * revert playground * typo * typo * Update lib/commons/dom/get-rect-stack.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update test/commons/dom/get-element-stack.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * fix Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
This was referenced Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was a fun one to debug. The problem was that our code incorrectly ordered the stack of elements that were positioned (i.e.
position: [absolute, relative, fixed]). Dug into the spec and found https://www.w3.org/Style/css2-updates/css2/zindex.html which mentioned that positioned elements and floated elements create their own stacking contexts if they don't have a z-index. So I modified our code to handle these "fake" stacking contexts and sort the elements correctly.A note about the
TODO, I have asked the Twitterverse if they can help give me some understanding, but for now I don't have an answer.Closes issue: #2851