Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd errors when importing aria/get-role #3281

Open
WilcoFiers opened this issue Nov 12, 2021 · 1 comment
Open

Odd errors when importing aria/get-role #3281

WilcoFiers opened this issue Nov 12, 2021 · 1 comment
Labels
tech debt Technical debt related tasks

Comments

@WilcoFiers
Copy link
Contributor

While working on #3275 I found that when I imported aria/get-role into dom/is-skip-link, axe-core for some reason completely broke. Just importing would do it. Did not require invoking getRole. I couldn't figure out the problem, and so moved passed it. I don't see how something like that could cause problems. There's clearly something going on in our build system that we don't understand. I would like to know what that is, so we don't run into this at a time where we don't have a simple work-around.

@WilcoFiers WilcoFiers added the tech debt Technical debt related tasks label Nov 12, 2021
@straker
Copy link
Contributor

straker commented Nov 12, 2021

I've determined the problem occurs with this import chain:

get-role -> implicit-role -> implicit-html-roles -> is-column-header / is-row-header -> get-scope -> to-grid

Memoize by that point should be defined up higher in the code since it's in utils, but for some reason is being put below the code that now needs it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Technical debt related tasks
Projects
None yet
Development

No branches or pull requests

2 participants