-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent crash on jsdom when preloading CSSOM #3754
fix: prevent crash on jsdom when preloading CSSOM #3754
Conversation
The fix LGTM. I don't understand what's going on with CI though. |
Thanks for the pr. Could you try pushing an empty commit to see if that fixes the checks?
|
- cssom package does not implement StyleSheet.media
e8d207b
to
98a0c7e
Compare
I used the @stephenmathieson could you re-approve so we'll see if CI is now stable? |
The CI seems to remain stuck. Any ideas what's going on? |
Unfortunately I don't know what's going on with Circle. I've looked around but it seems the only answer is to contact Circle support and see if they can fix it. Before I do that though, I'm going to try committing to your pr and see if that triggers the build. |
Well that seems to have worked. |
Reviewed for security |
<< Describe the changes >>
Adds a simple
if
to check whetherStyleSheet
hasmedia
.Closes #3753