Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dom.focusDisabled,dom.isVisibleForScreenreader): support the inert attribute #3857

Merged
merged 3 commits into from
Jan 19, 2023
Merged

feat(dom.focusDisabled,dom.isVisibleForScreenreader): support the inert attribute #3857

merged 3 commits into from
Jan 19, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Jan 16, 2023

Also adds dom.isInert.

Closes #3448

@straker straker requested a review from a team as a code owner January 16, 2023 21:27
@straker straker changed the title feat(dom.focus-disabled,dom.is-visible-for-screenreader): support the inert attribute feat(dom.focusDisabled,dom.isVisibleForScreenreader): support the inert attribute Jan 16, 2023
WilcoFiers
WilcoFiers requested changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you know what, we should have some integration tests for this.

I'm also wondering if we should do anything about firefox's lack of support. Thoughts?

@straker
Copy link
Contributor Author

straker commented Jan 17, 2023

Firefox has it behind a flag, so we could either assume it'll get released eventually or use 'inert' in HTMLElement.prototype to detect support for inert before returning true/false.

@straker straker merged commit 273c971 into develop Jan 19, 2023
@straker straker deleted the inert branch January 19, 2023 22:00
@attest-team-ci attest-team-ci mentioned this pull request Jan 20, 2023
Closed
@attest-team-ci attest-team-ci mentioned this pull request Apr 17, 2023
Merged
@Shubhabrata08 Shubhabrata08 mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the HTML inert attribute
2 participants
@straker @WilcoFiers