Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color-contrast): correctly calculate contrast of flex/grid items with z-index #3884

Merged
merged 8 commits into from
Jan 25, 2023
Merged

fix(color-contrast): correctly calculate contrast of flex/grid items with z-index #3884

merged 8 commits into from
Jan 25, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Jan 23, 2023

Closes: #3881

@straker straker requested a review from a team as a code owner January 23, 2023 22:37
WilcoFiers
WilcoFiers previously requested changes Jan 25, 2023
View reviewed changes
lib/commons/dom/create-grid.js Outdated Show resolved Hide resolved
lib/commons/dom/create-grid.js Outdated Show resolved Hide resolved
test/integration/rules/color-contrast/color-contrast.html Outdated Show resolved Hide resolved
test/commons/dom/get-element-stack.js Outdated Show resolved Hide resolved
straker and others added 5 commits January 25, 2023 08:12
@straker straker merged commit cef96be into develop Jan 25, 2023
@straker straker deleted the flex-items-zindex branch January 25, 2023 18:12
@attest-team-ci attest-team-ci mentioned this pull request Apr 17, 2023
Merged
@Shubhabrata08 Shubhabrata08 mentioned this pull request Jan 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color-contrast incorrect stack due to flex children allowing z-index
2 participants
@straker @WilcoFiers