fix(focus-order-semantics): Add ARIA role article to list of valid roles for scrollable regions #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipjia123
changed the title
…cake-7pr9w4q7473p7jj
|
@philipjia123 Thanks for the pr. Did you mean to open this as a draft? |
Oh d'oh, sorry didn't realize it was just sitting as a draft! |
…cake-7pr9w4q7473p7jj
straker
approved these changes
Mar 7, 2023
straker
changed the title
|
Wonderful, thanks Steven! |
philipjia123
deleted the
codespace-philipjia123-laughing-space-pancake-7pr9w4q7473p7jj
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(check): Add ARIA role
articleto list of valid roles for scrollable regions invalid-scrollable-semanticscheck and update tests.Closes: #3905