fix(d.ts): Add missing types for public axe methods #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
approved these changes
Mar 28, 2023
Merged
hamax
added a commit
to hamax/axe-core
that referenced
this pull request
Jul 5, 2023
I think this was unintentionally changed in dequelabs#3966. From check definitions we can see that many of them don't specify the incomplete message, because they don't have incomplete as a possible result.
hamax
added a commit
to hamax/axe-core
that referenced
this pull request
Jul 5, 2023
I think this was unintentionally changed in dequelabs#3966. From check definitions we can see that many of them don't specify the incomplete message, because they don't have incomplete as a possible result.
WilcoFiers
pushed a commit
that referenced
this pull request
Jul 19, 2023
* fix(d.ts): target selector type for shadow dom Before shadow dom support string[] was the correct type for the returned selectors. From code we can see that SerialDqElement.selector is used to populate this, so the type should also be the same. * feat(d.ts): add missing properties to the RelatedNode interface RelatedNode should have the same selectors and the same element reference as NodeResult. These are populated in process-aggregate.js. * fix(d.ts): incomplete message should be optional I think this was unintentionally changed in #3966. From check definitions we can see that many of them don't specify the incomplete message, because they don't have incomplete as a possible result. * feat(d.ts): add stronger typing to Check evaluate and after functions More precise types make it easier to write these function in typescript. With this change, complier knows about this.data, this.async, etc. * feat(d.ts): allow rule.matches to be a function Like evaluate and after, matches can also be a string or a function, but this is not currently represented in types. * fix(d.ts): tags and actIds should be on Rule and not RuleMetadata The rule metadata object expected in this.configure and the one returned by getRules are not the same. From the code we can see that tags and actIds are read from the rule itself and not from the metadata object. * feat(d.ts): add types for more utils and commons functions
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add types for various missing public options and methods:
Closes: #3965