Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory issue causing browser crash #4045

Closed
1 task done
nolandanley opened this issue May 31, 2023 · 2 comments · Fixed by #4059
Closed
1 task done

Memory issue causing browser crash #4045

nolandanley opened this issue May 31, 2023 · 2 comments · Fixed by #4059
Assignees
@WilcoFiers
Labels
fix Bug fixes

Comments

@nolandanley
Copy link
Contributor

Product

axe-core

Product Version

v4.7.1

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

We had reports of some tools within our company that used axe-core crashing because of memory issues on certain pages. Someone investigated this and found 2 places where VirtualNode references are retained after teardown().

  1. recycledLocalVariables
  2. channels

The second one seems to be causing the most issues. There's a timeout, but it doesn't seem to clean up the handlers.

This is not a blocking issue for us right now. We have a way of working around it in our tools, so it's not as high of a priority for us to get resolved as it would be otherwise.
@nolandanley nolandanley added the ungroomed Ticket needs a maintainer to prioritize and label label May 31, 2023
@straker
Copy link
Contributor

straker commented Jun 1, 2023

Thanks for letting us know about the memory issues.

@straker straker added fix Bug fixes and removed ungroomed Ticket needs a maintainer to prioritize and label labels Jun 1, 2023
@straker straker added this to the Axe-core 4.8 milestone Jun 1, 2023
@Sandrakay49

This comment was marked as spam.

Sign in to view
@WilcoFiers WilcoFiers self-assigned this Jun 19, 2023
@WilcoFiers WilcoFiers mentioned this issue Jun 19, 2023
Merged
@WilcoFiers WilcoFiers removed this from the Axe-core 4.8 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WilcoFiers WilcoFiers

Labels
fix Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid memory issues by doing better cleanup dequelabs/axe-core
4 participants
@WilcoFiers @straker @nolandanley @Sandrakay49