-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aria-allowed-role): add meter to allowed roles for named img #4055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr. Would you be able to add a test for this is test/integration/aria-allowed-role.html. Just adding an image tag with the new role and an id that will need to be added to the companion json file pass section.
added |
Thanks. The element will need an |
test/integration/rules/aria-allowed-role/aria-allowed-role.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for doing that.
Reviewed for security.
closes #4054
as stated in the PR title, this adds the meter element to be an allowed role for the img element when it is provided an accessible name.