Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils/clone): don't try to clone elements from different window context #4072

Merged
merged 9 commits into from
Jun 30, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 28, 2023

Cleaned up the code to match return early coding. Also noticed that we don't support circular references so went ahead and added a way to handle that so we don't end up in a maximum call stack error again.

Closes #3864

@straker straker requested a review from a team as a code owner June 28, 2023 23:17
lib/core/utils/clone.js Outdated Show resolved Hide resolved
lib/core/utils/clone.js Outdated Show resolved Hide resolved
WilcoFiers
WilcoFiers previously approved these changes Jun 29, 2023
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, left it with a suggestion though. Thoughts?

lib/core/utils/clone.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axe.run crashes if an iframe's contentDocument is used
2 participants