fix(aria-allowed-attr): pass aria-expanded on checkbox & switch #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All roles reviewed to largely remove (but in a few cases add) `aria-expanded` as a supported attribute. This matches both work done in ARIA 1.2 to correct for roles that should not have allowed the attribute, while also incorporating some ARIA 1.2 updates where some roles had support for the attribute added. closes #3339
…o scottaohara-patch-1
straker
previously requested changes
Aug 1, 2023
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
straker
previously approved these changes
Aug 2, 2023
dbjorge
approved these changes
Aug 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAI-ARIA 1.3 has proposed to dramatically change which roles allow aria-expanded. Per this PR,
checkboxandswitchnow allow this attribute. Quite a few more roles no longer allowaria-expanded.I've opened up an issue requesting that ARIA 1.3 deprecate aria-expanded on those roles, instead of simply removing them. I think simply removing them would create a lot of unnecessary friction. If the W3C decides not to stay backward compatible we may have to figure out a different way to present this, but by far the best solution here would be to use deprecation, which is what they've also done in other places. See w3c/aria#1990
Closes #3339, closes #3343