Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in d.ts on rawEnv #4217

Closed
WilcoFiers opened this issue Oct 25, 2023 · 0 comments · Fixed by #4218
Closed

Typo in d.ts on rawEnv #4217

WilcoFiers opened this issue Oct 25, 2023 · 0 comments · Fixed by #4218
Assignees
Labels
typescript TypeScript issues

Comments

@WilcoFiers
Copy link
Contributor

Instead of rawEnv the allowed reporter type is raw-env. This is incorrect. More generally, it is a little bit of a problem that the types only allow pre-existing axe-core reporters, since someone could add their own. Perhaps this just needs to allow all strings? That's quite permissive though. I wouldn't mind some intermediate where you can use a reporter name if you give some indication its available, but if you haven't, only the defaults are available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript TypeScript issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant