Bunch of fixes for IE and Edge #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wilco Fiers seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
marcysutton
reviewed
Oct 20, 2017
lib/commons/text/index.js
Outdated
|
|
||
| var text = commons.text = {}; | ||
| // These defaults are only available in IE and Edge | ||
| const input = document.createElement('input'); |
There was a problem hiding this comment.
Should we remove the input after commons.text is done with it to clear up memory?
| // IE inserts this for us, thanks! | ||
| assert.equal(axe.commons.text.accessibleTextVirtual(target), target.value || 'Submit'); | ||
| assert.equal(axe.commons.text.accessibleTextVirtual(target), target.actualNode.value || 'Submit'); |
There was a problem hiding this comment.
I'm surprised that worked elsewhere without actualNode
There was a problem hiding this comment.
It's undefined, so the || ensures it's always Submit.
mrtnvh
pushed a commit
to mrtnvh/axe-core
that referenced
this pull request
Nov 24, 2023
…ples/shadow-dom (dequelabs#577) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed all but one issue with IE and Edge. The one issue still open is a color-contrast one, for some reason overlap wasn't getting caught in IE, if the element existed below the fold.