feat(collect-results-from-frames): add frameWaitTime option #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcysutton
reviewed
Dec 19, 2017
| frame.addEventListener('load', function () { | ||
| var context = new Context(document); | ||
| var params = { frameWaitTime: 90000 }; | ||
| axe.utils.collectResultsFromFrames(context, params, 'stuff', 'morestuff', noop, |
There was a problem hiding this comment.
Is there a way to also cover this in an integration test, so we can make sure it works from axe.run?
There was a problem hiding this comment.
specifically, across iframes
There was a problem hiding this comment.
Good idea. I've added an integration test.
isner
force-pushed
the
config-frame-timeout
branch
from
73ca368
to
da1aba4
Compare
WilcoFiers
approved these changes
Jan 4, 2018
marcysutton
approved these changes
Jan 18, 2018
marcysutton
pushed a commit
that referenced
this pull request
Jan 18, 2018
|
Also merged to develop-2x. Thanks Matt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #660