Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't crash with slot elements without shadowDOM #977

Merged
merged 2 commits into from
Jun 28, 2018
Merged

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented Jun 27, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

Description of the changes

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@WilcoFiers WilcoFiers requested a review from dylanb June 27, 2018 20:50
@WilcoFiers WilcoFiers changed the title fix: Don't crash with slot elements without shadowDOM Wilco Fiers committed fix: Don't crash with slot elements without shadowDOM Jun 27, 2018
@@ -231,6 +231,13 @@ describe('axe.utils.getFlattenedTree', function() {
assert.equal(virtualDOM[0].actualNode, vNode.actualNode);
});
});
} else {

This comment was marked as resolved.

@WilcoFiers WilcoFiers merged commit cc044af into develop Jun 28, 2018
@WilcoFiers WilcoFiers deleted the slot-fix branch June 28, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getFlattenedTree can crash with <slot> elements without shadowDOM support
2 participants