Skip to content
This repository has been archived by the owner on Mar 19, 2021. It is now read-only.

feat(*): convert to typescript #137

Merged
merged 6 commits into from
Feb 21, 2020
Merged

feat(*): convert to typescript #137

merged 6 commits into from
Feb 21, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Feb 19, 2020

This one was a bit tricky with all the private property lookups in axe-core and React.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things.

index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small thing. This LGTM tho!

index.ts Outdated Show resolved Hide resolved
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please get a second approval on this tho. I am not very familiar with this project.

index.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed 2 minor things

Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, I don't see anything glaring

@straker straker merged commit 261d358 into develop Feb 21, 2020
@straker straker deleted the typescript branch February 21, 2020 16:09
@straker straker mentioned this pull request Feb 21, 2020
2 tasks
@dgrant85
Copy link

Has this been released?

Version pulled from npm does not include type declarations and is listed on npmjs.com as 3.4.1, whereas develop is currently at 3.4.0?

@straker
Copy link
Contributor Author

straker commented May 27, 2020

It does not appear types was released to npm. As for the version discrepancy, seems we never pulled master back into develop after the release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants