fix: test suite #30
fix: test suite #30
Conversation
This patch updates the build process and fixes the test suite. Notable changes: - The "grunt" dependency has been removed (along with `Gruntfile.js`); instead, we just call `browserify` directly. - Babel is run via the `babelify` transform. - The CSS (services.css) is now properly included in the build. - The `webcomponents.js` dependency is now imported into the build rather than arbitrary copied into the `dist/` directory. This is required before we can tackle #29. /cc @WilcoFiers
|
|
example/package.json
Outdated
| @@ -21,12 +22,22 @@ | |||
| "devDependencies": { | |||
| "babel-preset-es2015": "^6.6.0", | |||
| "babel-preset-react": "^6.5.0", | |||
| "babelify": "^8.0.0", | |||
There was a problem hiding this comment.
This was complaining that I needed babel-core. Do we need to add that?
There was a problem hiding this comment.
Whoops, yes. It's a peer dependency of babelify. Will update.
Are you able to adjust the commit message when squashing this in? I am still not super familiar with "conventional commits", but their documentation suggests that the "final burden" of commit messages falls on the maintainer(s) of the project. If not, I can adjust the commit message myself and force push, but this seems like an additional (and unnecessary) burden. |
Happy to squash. You can use |
This patch updates the build process and fixes the test suite.
Notable changes:
Gruntfile.js); instead, we just callbrowserifydirectly.babelifytransform.webcomponents.jsdependency is now imported into the build rather than arbitrary copied into thedist/directory.This is required before we can tackle #29.
/cc @WilcoFiers