Fix "Mark Range": reduce maximum namespaces in favorites, fix shadowing of ctrl+space

[zkck]

Fixes #2187 (at least "Mark Range")

Hello!

The "Mark Range" command seems to have remained broken. I used delve to investigate the problem, and it seems that the problem is in func namespaceActions: we lookup the missing key 10 in ui.NumKeys, giving back 0 (empty value for int), corresponding to tcell.KeyCtrlSpace, and breaking "Mark Range".

This may be due to the increase to MaxFavoriteNS added by #2881: number keys are added for each namespace in favorites plus the all namespace, so MaxFavoriteNS should be 9. I reduced MaxFavoriteNS back to 9, and added a check in func namespaceActions for when we go beyond ui.Key9, while removing the need for the ui.NumKeys.

Thanks again for k9s! Let me know if you see any issues with my PR :)

[derailed]

@gerhard Nice catch! Thank you for this update

[derailed]

I think all we need here is to make sure the key is within the index range.

		if k, ok := ui.NumKeys[index]; ok {
			aa.Add(k, ui.NewKeyAction(ns, b.switchNamespaceCmd, true))
			b.namespaces[index] = ns
			index++
		} else {
			log.Warn().Msgf("No more keys available for namespace %s: %d of %d]. Skipping...", ns, index, data.MaxFavoritesNS)
		}

[zkck]

Alright 👍 will change it. However maybe the index++ needs to be after the if/else block, otherwise index will just remain stuck on a missing key and wouldn't correspond with the namespace index. Or we can just assume that keys are no longer available and break after the warning

[zkck]

Added the check, here we can see the output (I set MaxFavoriteNS back to 10 to test this)

[derailed]

@zkck Thanks for the updates!