Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proper blocking usage #298

Closed
RiccardoM opened this issue Oct 14, 2020 · 1 comment · Fixed by #309
Closed

Implement proper blocking usage #298

RiccardoM opened this issue Oct 14, 2020 · 1 comment · Fixed by #309
Assignees
@leobragaz
Labels
kind/new-feature Propose the addition of a new feature that does not yet exist x/profiles Module that allows to create and manage decentralized social profiles
Milestone
v0.14.0

Comments

@RiccardoM
Copy link
Contributor

Feature description

Currently, when a user blocks another user that blockage is never considered anywhere. Instead, we should consider it when:

  1. a blocked user asks for the DTag of the blocking user;
  2. a blocked user adds a relationship towards the blocking user.

Implementation proposal

What I think we should do is the following:

  1. when a DTag transferring request is made from Alice to Bob, check if Bob has blocked Alice. If so, return an error and halt the process;

  2. when a relationships is created from Alice towards Bob, check if Bob has blocked Alice. If so, return an error and halt the process.
@RiccardoM RiccardoM added kind/new-feature Propose the addition of a new feature that does not yet exist x/profiles Module that allows to create and manage decentralized social profiles labels Oct 14, 2020
@RiccardoM RiccardoM added this to the v0.14.0 milestone Oct 14, 2020
@leobragaz
Copy link
Contributor

After we close the v0.13.0 I will star with this

@leobragaz leobragaz self-assigned this Oct 20, 2020
@leobragaz leobragaz mentioned this issue Oct 21, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leobragaz leobragaz

Labels
kind/new-feature Propose the addition of a new feature that does not yet exist x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging a pull request may close this issue.

User block integration desmos-labs/desmos
2 participants
@RiccardoM @leobragaz