From 2a75fc11d338c814ff0e3f8e980e859b7e98d691 Mon Sep 17 00:00:00 2001 From: danielkubat Date: Tue, 18 Aug 2020 22:38:08 +0200 Subject: [PATCH 1/3] permissions explicitly defined Signed-off-by: danielkubat --- tasks/sysctl.yml | 1 + tasks/yum.yml | 2 ++ 2 files changed, 3 insertions(+) diff --git a/tasks/sysctl.yml b/tasks/sysctl.yml index 7a6d83b49..12ca47ded 100644 --- a/tasks/sysctl.yml +++ b/tasks/sysctl.yml @@ -72,6 +72,7 @@ template: src: 'etc/default/ufw.j2' dest: '/etc/default/ufw' + mode: 0644 when: - ufw_manage_defaults - ansible_facts.distribution in ['Debian', 'Ubuntu'] diff --git a/tasks/yum.yml b/tasks/yum.yml index 9d6599ae6..5208200bc 100644 --- a/tasks/yum.yml +++ b/tasks/yum.yml @@ -23,6 +23,7 @@ path: '{{ item.path }}' regexp: '^\s*gpgcheck.*' replace: 'gpgcheck=1' + mode: preserve with_items: - '{{ yum_repos.files | default([]) }}' @@ -34,6 +35,7 @@ path: '{{ item }}' regexp: '^\s*gpgcheck\W.*' replace: 'gpgcheck=1' + mode: preserve register: status failed_when: status.rc is defined and status.rc != 257 loop: From 34abe1ab03715bfb8d714dc7ea6a607f3e23ab74 Mon Sep 17 00:00:00 2001 From: danielkubat Date: Tue, 18 Aug 2020 22:50:10 +0200 Subject: [PATCH 2/3] mode defined in octal form Signed-off-by: danielkubat --- tasks/yum.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tasks/yum.yml b/tasks/yum.yml index 5208200bc..5ca08ccf9 100644 --- a/tasks/yum.yml +++ b/tasks/yum.yml @@ -23,7 +23,7 @@ path: '{{ item.path }}' regexp: '^\s*gpgcheck.*' replace: 'gpgcheck=1' - mode: preserve + mode: 0644 with_items: - '{{ yum_repos.files | default([]) }}' @@ -35,7 +35,7 @@ path: '{{ item }}' regexp: '^\s*gpgcheck\W.*' replace: 'gpgcheck=1' - mode: preserve + mode: 0644 register: status failed_when: status.rc is defined and status.rc != 257 loop: From fd10d8e8d299c4410ccf376cb74d1f4001b3a073 Mon Sep 17 00:00:00 2001 From: danielkubat Date: Tue, 18 Aug 2020 23:50:46 +0200 Subject: [PATCH 3/3] single quotes added to follow role formatting Signed-off-by: danielkubat --- tasks/sysctl.yml | 2 +- tasks/yum.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tasks/sysctl.yml b/tasks/sysctl.yml index 12ca47ded..ecd3a375d 100644 --- a/tasks/sysctl.yml +++ b/tasks/sysctl.yml @@ -72,7 +72,7 @@ template: src: 'etc/default/ufw.j2' dest: '/etc/default/ufw' - mode: 0644 + mode: '0644' when: - ufw_manage_defaults - ansible_facts.distribution in ['Debian', 'Ubuntu'] diff --git a/tasks/yum.yml b/tasks/yum.yml index 5ca08ccf9..bf58972cf 100644 --- a/tasks/yum.yml +++ b/tasks/yum.yml @@ -23,7 +23,7 @@ path: '{{ item.path }}' regexp: '^\s*gpgcheck.*' replace: 'gpgcheck=1' - mode: 0644 + mode: '0644' with_items: - '{{ yum_repos.files | default([]) }}' @@ -35,7 +35,7 @@ path: '{{ item }}' regexp: '^\s*gpgcheck\W.*' replace: 'gpgcheck=1' - mode: 0644 + mode: '0644' register: status failed_when: status.rc is defined and status.rc != 257 loop: