-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os_security_kernel_enable_sysrq is not implemented #115
Comments
Yes there are actually more sysctl-settings missing. We forgot to add them back when we changed where the sysctl-vars are defined. It happened here: 8747be1, our testing was not good then. If you want, you can fix this. It should just be a matter of adding all parameters according to linux-baseline in You'll have to test locally with vagrant though, because in docker setting sysctl-settings does not work. |
Do you want to maintain Ansible 1.9 compatibility? Because with 2.x we could nicely combine dictionaries and allow defining only the delta settings instead of forcing user to define the whole 1.9 is already three releases behind. |
As for 1.9 support, see this thread: #110 For combining, I guess you mean the combine filter. Yes, that's a good idea. |
Yes and yes. I am going to review the whole playbook anyway, so will gladly contribute. |
Closed by #120 |
Despite
README.md
claiming otherwise, theos_security_kernel_enable_sysrq
setting (corresponding to "sysctl-30: Kernel Parameter kernel.sysrq value should eq 0" from linux-baseline) is not implemented in this Ansible role at all.taking a look if I can fix it
The text was updated successfully, but these errors were encountered: