add passwd task, control os-03 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypid
requested changes
Aug 5, 2017
tasks/minimize_access.yml
Outdated
| @@ -18,9 +18,16 @@ | |||
| when: item.stat.isdir | |||
| with_items: "{{ minimize_access_directories.results }}" | |||
|
|
|||
| - name: change shadow ownership to root and mode to 0600 | DTAG SEC Req 3.21-7 | |||
| - name: change shadow ownership to {{ os_shadow_perms.owner }}.{{ os_shadow_perms.group }} and mode to {{ os_shadow_perms.mode }} | os-03 | |||
| file: dest='/etc/shadow' owner={{ os_shadow_perms.owner }} group={{ os_shadow_perms.group }} mode={{ os_shadow_perms.mode }} | |||
There was a problem hiding this comment.
Seems like you duplicated this task above (new task is below) and changed it to proper YAML syntax. Sounds like you can remove the above task now?
There was a problem hiding this comment.
Well actually I wanted to to add a new task to harden passwd, but failed while copy-pasting. I'll fix that.
rndmh3ro
changed the title
|
Now the PR is done, @ypid could you please make a review? |
rndmh3ro
added a commit
that referenced
this pull request
Jul 24, 2020
allow configuration of GatewayPorts
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
add passwd task, control os-03
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
allow configuration of GatewayPorts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.