Fix core dump config file creation when core dumps are disabled #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndmh3ro
requested changes
Aug 14, 2018
tasks/limits.yml
Outdated
| @@ -32,11 +32,4 @@ | |||
| path: /etc/security/limits.d/10.hardcore.conf | |||
| state: absent | |||
|
|
|||
There was a problem hiding this comment.
Can you remove this empty line, too? This way its more obvious that the condition belongs to the task above.
|
You're right, thanks for noticing! Can you also please change the setting here from false to true? false is the default so its not making any sense here. |
rndmh3ro
approved these changes
Aug 23, 2018
|
Thank you! :) |
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
Fix core dump config file creation when core dumps are disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that something went wrong when PR #146 was merged to master.
When variable
os_security_kernel_enable_core_dumpis set tofalsethe core dump configuration file/etc/security/limits.d/10.hardcore.confwill always be removed by the following task:https://github.com/dev-sec/ansible-os-hardening/blob/30aa3fef3fb47c620369b617a78b0644b69e0082/tasks/limits.yml#L30
In addition, if
os_security_kernel_enable_core_dumpis set totrue, a core dump config file will be created by mistake:https://github.com/dev-sec/ansible-os-hardening/blob/30aa3fef3fb47c620369b617a78b0644b69e0082/tasks/limits.yml#L35