Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode to su-binary task. Fix #38 #39

Merged
merged 2 commits into from
Sep 1, 2015
Merged

Add mode to su-binary task. Fix #38 #39

merged 2 commits into from
Sep 1, 2015

Conversation

rndmh3ro
Copy link
Member

No description provided.

@@ -14,5 +14,5 @@
file: dest='/etc/shadow' owner=root group=root mode=0600

- name: change su-binary to only be accessible to user and group root
file: dest='/bin/su' owner=root group=root mode
file: dest='/bin/su' owner=root group=root mode=0750
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May use YAML syntax to make such problems more obvious? E.g:

- file:
    dest: '/bin/su'
    owner: 'root'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, ansible should throw an error when a key is provided without a value. I'd rather not change the whole syntax because I like it that way.

This does throw an error. Altough we should test it correctly!;)
I'll change the tests and leave the syntax like it is.

chris-rock added a commit that referenced this pull request Sep 1, 2015
Add mode to su-binary task. Fix #38
@chris-rock chris-rock merged commit 91ecc19 into master Sep 1, 2015
@chris-rock chris-rock deleted the su_mode branch September 1, 2015 21:21
@chris-rock
Copy link
Member

Thanks @rndmh3ro

rndmh3ro pushed a commit that referenced this pull request Jul 24, 2020
bugfix. Now option true for PrintLastLog is available again
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
bugfix. Now option true for PrintLastLog is available again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants