Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration of root keys via databag and attributes #37

Closed
chris-rock opened this issue Sep 5, 2014 · 3 comments
Closed

Configuration of root keys via databag and attributes #37

chris-rock opened this issue Sep 5, 2014 · 3 comments

Comments

@chris-rock
Copy link
Member

The current version uses databags only:
https://github.com/TelekomLabs/chef-ssh-hardening/blob/master/recipes/server.rb#L74-L79

We should support databags and attributes and merge the the keys. Simple flags should enable users to deactivate databag or attributes usage.

Thanks @bkw for reporting this.

@bkw
Copy link
Contributor

bkw commented Sep 5, 2014

Actually, I'm fine with just supporting data bags. The thing that bit me was that the recipe insists on the databag to exist (although it is perfectly fine with an empty data bag).
That's why I always have to do a "mkdir data_bags/users" prior to runnning my chefspec tests.
Wrapping the access to the data bag into a check whether such a data bag exists would be enough for me.

@bkw
Copy link
Contributor

bkw commented Oct 14, 2014

... and I somehow feel that a PR for just that is about to hit an inbox near you very soon. But now for some sleep...

@chris-rock
Copy link
Member Author

fixed with #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants