Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt-packages v.s. apt-get-packages #206

Closed
eitsupi opened this issue Dec 17, 2022 · 4 comments
Closed

apt-packages v.s. apt-get-packages #206

eitsupi opened this issue Dec 17, 2022 · 4 comments

Comments

@eitsupi
Copy link

eitsupi commented Dec 17, 2022

Hi, @danielbraun89.
You have recently released apt-get-packages in ccd4c1f, but there is already a functionality equivalent to this that has been released.

https://github.com/rocker-org/devcontainer-features/blob/main/src/apt-packages

Were you aware of this?
Wouldn't it be better to manage one jointly than two similar ones?

I have run into this same thing in the past.
devcontainers/spec#155

@danielbraun89
Copy link
Member

danielbraun89 commented Dec 17, 2022

@eitsupi
I was not at all aware about your apt-packages feature😅 (my apt-get-packages was part of a larger attempt to have more generic features as per #172 (for example I have also added npm-package , pipx-package and asdf-package)

I fully agree it would be better to be maintained jointly!

As I see that my feature has not yet been "grabbed" by github ill just delete the feature package, If we are lucky it will be enough to prevent from the headache of deprecating it later

On another note - considering that a minor feature like k9s has already 1 2 and 3 implementations -and that this devcontainer feature framework is really still in its infancy, it is inevitable that someone somewhen will reimplement this yet again. but one step at a time!

@eitsupi
Copy link
Author

eitsupi commented Dec 18, 2022

Thanks for your quick response!

This is a really basic feature that I had hoped would be implemented in devcontainers/features (devcontainers/features#67) but no progress was made so I published it from rocker-org (since it is useful in combination with other rocker-org' Features).
Since common-utils version2 now supports not only apt but also dnf and apk, I expect that perhaps in the future more generic Feature will be implemented in devcontainers/features.

As I see that my feature has not yet been "grabbed" by github ill just delete the feature package, If we are lucky it will be enough to prevent from the headache of deprecating it later

Since which Features are published is recorded as metadata as https://github.com/devcontainers-contrib/features/pkgs/container/features, deleting only the Feature is insufficient.
We must remove the Feature from in the src/ directory and then run the publish action again to update the metadata.
(See devcontainers/spec#155)

On another note - considering that a minor feature like k9s has already 1 2 and 3 implementations -and that this devcontainer feature framework is really still in its infancy, it is inevitable that someone somewhen will reimplement this yet again.

No doubt.

@danielbraun89
Copy link
Member

done in 006e18e

@eitsupi
Copy link
Author

eitsupi commented Dec 19, 2022

Thanks!

@eitsupi eitsupi closed this as completed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants