Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request][common-utils]: add additionalPackages option #537

Open
raymond-chetty opened this issue Apr 28, 2023 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@raymond-chetty
Copy link
Contributor

raymond-chetty commented Apr 28, 2023

common-utils currently adds common packages depending on the distribution. This task would expand the functionality with a new option called additionalPackages that would simply pass the package manager additional packages for installing.

It looks like there is a feature which does this and it sounds like the author believes common-utils might be a good place for such functionality to move into.

Comment from #67

Hi, I published `apt-packages` Feature to install apt packages.
https://github.com/rocker-org/devcontainer-features/tree/main/src/apt-packages

Something better than (perhaps supports more than just apt?) may become available here in the future, but for now we can use it to install any apt package without a Dockerfile.

 _Originally posted by @eitsupi in 
https://github.com/devcontainers/features/issues/67#issuecomment-1346642565_

Alternately move https://github.com/rocker-org/devcontainer-features/tree/main/src/apt-packages into https://github.com/devcontainers/features and expand to work on alpine and redhat.

Possible name: native-package-manager

@raymond-chetty raymond-chetty changed the title Feature Request: add additionalPackages option [Feature Request][common-utils]: add additionalPackages option Apr 30, 2023
@samruddhikhandale
Copy link
Member

Hi 👋

Thanks for this Feature option request, I like this idea of adding a new additionalPackages which works similar to https://github.com/rocker-org/devcontainer-features/tree/main/src/apt-packages.

From https://github.com/devcontainers/features/tree/main/src/common-utils#os-support 👇

This Feature should work on recent versions of Debian/Ubuntu, RedHat Enterprise Linux, Fedora, RockyLinux, and Alpine Linux.

As you pointed out before, we'd need to ensure it works with all types of currently supported OS.

@raymond-chetty would you be interested in opening a PR with these changes? We highly appreciate community contributions, I could help review the PR.

@samruddhikhandale samruddhikhandale added the enhancement New feature or request label May 2, 2023
@raymond-chetty
Copy link
Contributor Author

I guess I'm interested. I'll let you know when I get to this. You can probably leave it unassigned for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants